ext/standard: validate mode is within 0..07777 #21152
Open
+52
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
reviewed
Feb 7, 2026
| --TEST-- | ||
| mkdir(): invalid mode | ||
| --FILE-- | ||
| <?php |
devnexen
approved these changes
Feb 8, 2026
Girgias
reviewed
Feb 9, 2026
ext/standard/file.c
Outdated
| Z_PARAM_RESOURCE_OR_NULL(zcontext) | ||
| ZEND_PARSE_PARAMETERS_END(); | ||
|
|
||
| if (mode < 0 || (mode & ~07777)) { |
Member
There was a problem hiding this comment.
I wonder if it makes sense to provide a Zend API for this. As a lot of code does file permissions checks (including INI settings (or should at least))
Contributor
Author
There was a problem hiding this comment.
I’ve created a helper function zend_validate_file_permissions(). I think this can be used to validate permission masks for any filesystem-related operations. Please let me know if this approach makes sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.